Skip to content

Move getting commits by tags to separate function #220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 26, 2023

Conversation

markovamaria
Copy link
Collaborator

This change is suggested for consistency of "trigger_tests_cli_command_logic" function on cli.py.
Added "get_commits_by_tag" and related unit test by analogue with earlier added "get_commits" (renamed to "get_commits_by_branch").

@markovamaria
Copy link
Collaborator Author

markovamaria commented Feb 24, 2023

This PR doesn't have changes from #216 and should be rebased after #216 merge or vise versa.

@markovamaria
Copy link
Collaborator Author

"Run TOX" is failing due to unused var. "Fixed" in #216

@markovamaria markovamaria self-assigned this Feb 24, 2023
@filipecosta90 filipecosta90 merged commit b63a28b into main Feb 26, 2023
@filipecosta90 filipecosta90 deleted the mmarkova/cli_commits_by_tag branch February 26, 2023 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants