Skip to content

Client runner: enabled oss cluster benchmarks for string (just set and get commands) benchmarks #200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 6, 2023

Conversation

filipecosta90
Copy link
Contributor

@filipecosta90 filipecosta90 commented Jan 23, 2023

Benchmarks that we can now use on an OSS cluster deployment (It implied that we moved from --command to --ratio ) :

  • memtier_benchmark-1Mkeys-load-string-with-100B-values-pipeline-10.yml
  • memtier_benchmark-1Mkeys-load-string-with-100B-values.yml
  • memtier_benchmark-1Mkeys-load-string-with-10B-values-pipeline-10.yml
  • memtier_benchmark-1Mkeys-load-string-with-10B-values.yml
  • memtier_benchmark-1Mkeys-load-string-with-1KiB-values.yml
  • memtier_benchmark-1Mkeys-string-get-100B-pipeline-10.yml
  • memtier_benchmark-1Mkeys-string-get-100B.yml
  • memtier_benchmark-1Mkeys-string-get-10B-pipeline-10.yml
  • memtier_benchmark-1Mkeys-string-get-10B.yml
  • memtier_benchmark-1Mkeys-string-get-1KiB-pipeline-10.yml
  • memtier_benchmark-1Mkeys-string-get-1KiB.yml

For the benchmarks that use --command on memtier we check for that keyword on the client arguments preparation and skip that benchmark when cluster-mode is enabled.

slice4e
slice4e previously approved these changes Feb 1, 2023
@slice4e
Copy link
Collaborator

slice4e commented Feb 1, 2023

approved

@filipecosta90 filipecosta90 requested a review from slice4e February 6, 2023 22:26
@slice4e slice4e merged commit be419d3 into main Feb 6, 2023
@slice4e slice4e deleted the oss.cluster.client.runner branch February 6, 2023 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants