Skip to content

Added SADD test variations discussed in redis/pull/11595 #198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 23, 2023

Conversation

filipecosta90
Copy link
Contributor

As being discussed in redis/redis#11595 (comment)

Copy link

@zuiderkwast zuiderkwast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

Although this benchmark is perhaps only useful for one PR. Every optimization needs its own special benchmark to prove it. What's your thoughts about that?

@filipecosta90
Copy link
Contributor Author

Nice.

Although this benchmark is perhaps only useful for one PR. Every optimization needs its own special benchmark to prove it. What's your thoughts about that?

Nice.

Although this benchmark is perhaps only useful for one PR. Every optimization needs its own special benchmark to prove it. What's your thoughts about that?

@zuiderkwast IMO it will still be useful to track SADD performance on a general benchmark ( we don't have specific sadd benchmarks on this spec yet ). So, lets add it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants