Skip to content

Updated dbconfig requests memory limit based uppon client runner checks #188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Dec 27, 2022

Conversation

filipecosta90
Copy link
Contributor

@filipecosta90 filipecosta90 commented Dec 26, 2022

Confirmation it works as expected

=============================================================================== 25 passed, 253 warnings in 235.55s (0:03:55) ===============================================================================
integration-tests run-test: commands[4] | coverage report -m
Name                                                                                          Stmts   Miss  Cover   Missing
---------------------------------------------------------------------------------------------------------------------------
redis_benchmarks_specification/__api__/__init__.py                                                0      0   100%
redis_benchmarks_specification/__api__/app.py                                                   118     17    86%   46-49, 54, 59-67, 76, 78, 115
redis_benchmarks_specification/__builder__/__init__.py                                            0      0   100%
redis_benchmarks_specification/__builder__/builder.py                                           186     54    71%   54-141, 163-164, 186, 213, 224-241, 254, 280, 326, 357, 365-371, 408-414, 423
redis_benchmarks_specification/__builder__/schema.py                                             13      0   100%
redis_benchmarks_specification/__cli__/__init__.py                                                0      0   100%
redis_benchmarks_specification/__cli__/args.py                                                   37      0   100%
redis_benchmarks_specification/__cli__/cli.py                                                   111     47    58%   44-55, 85, 99-111, 126, 141-172, 175, 188, 196-211, 225-259
redis_benchmarks_specification/__cli__/stats.py                                                 262    254     3%   19-403
redis_benchmarks_specification/__common__/__init__.py                                             0      0   100%
redis_benchmarks_specification/__common__/builder_schema.py                                      86     11    87%   53, 81-86, 103-106, 114, 151
redis_benchmarks_specification/__common__/env.py                                                 45      1    98%   79
redis_benchmarks_specification/__common__/package.py                                             19     11    42%   10-21
redis_benchmarks_specification/__common__/runner.py                                              85     13    85%   22, 27, 29-40, 45, 50-51, 119-120
redis_benchmarks_specification/__common__/spec.py                                                22      0   100%
redis_benchmarks_specification/__init__.py                                                        6      2    67%   14-15
redis_benchmarks_specification/__runner__/__init__.py                                             0      0   100%
redis_benchmarks_specification/__runner__/args.py                                                44      0   100%
redis_benchmarks_specification/__runner__/runner.py                                             371    116    69%   92-100, 105-106, 142-150, 166-174, 176, 233, 249-252, 262-310, 376, 385-386, 416, 441-448, 491-496, 508-518, 523-540, 550-556, 559-560, 563, 595-596, 602, 624, 732-733, 799-808, 812-821, 824-834, 838, 843-844, 864-873, 876, 886-891, 895-901, 969-1037
redis_benchmarks_specification/__self_contained_coordinator__/__init__.py                         0      0   100%
redis_benchmarks_specification/__self_contained_coordinator__/args.py                            31     28    10%   25-138
redis_benchmarks_specification/__self_contained_coordinator__/artifacts.py                       12      0   100%
redis_benchmarks_specification/__self_contained_coordinator__/build_info.py                      36      2    94%   20, 36
redis_benchmarks_specification/__self_contained_coordinator__/clients.py                          8      0   100%
redis_benchmarks_specification/__self_contained_coordinator__/cpuset.py                          11      0   100%
redis_benchmarks_specification/__self_contained_coordinator__/docker.py                          27     14    48%   37-46, 59-90
redis_benchmarks_specification/__self_contained_coordinator__/prepopulation.py                   22     14    36%   28-86
redis_benchmarks_specification/__self_contained_coordinator__/runners.py                        195    158    19%   88-89, 120-620
redis_benchmarks_specification/__self_contained_coordinator__/self_contained_coordinator.py     322    129    60%   94-228, 285, 317, 325, 351, 401-407, 411, 420-425, 482-491, 567, 693-768, 775, 827-845, 860-869, 881-891, 973-978
redis_benchmarks_specification/__setups__/__init__.py                                             0      0   100%
redis_benchmarks_specification/__setups__/topologies.py                                          13      0   100%
---------------------------------------------------------------------------------------------------------------------------
TOTAL                                                                                          2082    871    58%
integration-tests docker: remove 'eb339ba56c' (from 'datasink')
integration-tests docker: remove '2207bea356' (from 'db_server')
_________________________________________________________________________________________________ summary __________________________________________________________________________________________________
  integration-tests: commands succeeded
  congratulations :)

@codecov-commenter
Copy link

codecov-commenter commented Dec 26, 2022

Codecov Report

Base: 59.35% // Head: 57.01% // Decreases project coverage by -2.34% ⚠️

Coverage data is based on head (74cf011) compared to base (e5938dd).
Patch coverage: 42.22% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #188      +/-   ##
==========================================
- Coverage   59.35%   57.01%   -2.35%     
==========================================
  Files          24       24              
  Lines        1811     2082     +271     
==========================================
+ Hits         1075     1187     +112     
- Misses        736      895     +159     
Impacted Files Coverage Δ
redis_benchmarks_specification/__cli__/stats.py 3.05% <0.00%> (-1.98%) ⬇️
...fication/__self_contained_coordinator__/runners.py 18.97% <0.00%> (-0.40%) ⬇️
...edis_benchmarks_specification/__runner__/runner.py 62.26% <62.24%> (-0.24%) ⬇️
...edis_benchmarks_specification/__common__/runner.py 84.70% <76.36%> (-15.30%) ⬇️
...tained_coordinator__/self_contained_coordinator.py 59.00% <87.50%> (-0.75%) ⬇️
redis_benchmarks_specification/__cli__/args.py 100.00% <100.00%> (ø)
redis_benchmarks_specification/__runner__/args.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@filipecosta90 filipecosta90 merged commit 62e9098 into main Dec 27, 2022
@filipecosta90 filipecosta90 deleted the test.fixes branch December 27, 2022 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants