Skip to content

Updated benchmark config to include resource memory usage. Checking valid memory settings upon CLI runner #186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Dec 26, 2022

Conversation

filipecosta90
Copy link
Contributor

@filipecosta90 filipecosta90 commented Dec 26, 2022

  • Include password option in benchmark runner
  • Removing numpy dep from project
  • Exporting memory and commandstats metrics
  • Updated benchmark config to include resource memory usage. Checking valid memory settings upon CLI runner

Confirmation of OK run:

$ tox 
integration-tests inst-nodeps: /home/fco/redislabs/redis-benchmarks-specification/.tox/.tmp/package/1/redis_benchmarks_specification-0.1.63.tar.gz
integration-tests installed: aniso8601==9.0.1,ansicolors==1.1.8,astor==0.8.1,async-timeout==4.0.2,attrs==22.1.0,bcrypt==4.0.1,black==22.3.0,boto3==1.26.30,botocore==1.29.30,certifi==2021.10.8,cffi==1.15.1,chardet==5.1.0,charset-normalizer==2.1.1,click==8.0.4,colorama==0.4.6,contourpy==1.0.6,coverage==7.0.1,cryptography==38.0.4,cycler==0.11.0,daemonize==2.5.0,DataProperty==0.55.0,decorator==5.1.1,Deprecated==1.2.13,distlib==0.3.6,docker==5.0.3,dominate==2.7.0,exceptiongroup==1.1.0,filelock==3.8.2,flake8==4.0.1,Flask==2.2.2,Flask-HTTPAuth==4.7.0,flask-restx==0.5.1,flynt==0.69,fonttools==4.38.0,gitdb==4.0.10,GitPython==3.1.29,humanize==2.6.0,idna==3.4,importlib-metadata==4.13.0,importlib-resources==5.10.1,iniconfig==1.1.1,invoke==1.6.0,isort==5.10.1,itsdangerous==2.1.2,Jinja2==3.1.2,jmespath==1.0.1,jsonpath-ng==1.5.3,jsonschema==4.17.3,kiwisolver==1.4.4,MarkupSafe==2.1.1,marshmallow==3.19.0,matplotlib==3.6.2,mbstrdecoder==1.1.1,mccabe==0.6.1,mock==4.0.3,mypy-extensions==0.4.3,node-semver==0.8.1,numpy==1.23.5,oyaml==1.0,packaging==22.0,pandas==1.5.2,paramiko==2.12.0,pathspec==0.10.3,pathvalidate==2.5.2,Pillow==9.3.0,pkgutil_resolve_name==1.3.10,platformdirs==2.6.0,pluggy==1.0.0,ply==3.11,psutil==5.9.4,py==1.11.0,py-cpuinfo==5.0.0,pycodestyle==2.8.0,pycparser==2.21,pyflakes==2.4.0,PyGithub==1.57,PyJWT==2.6.0,PyNaCl==1.5.0,pyparsing==3.0.9,pyrsistent==0.19.2,pysftp==0.2.9,pytablewriter==0.64.2,pytest==7.2.0,pytest-asyncio==0.20.3,pytest-cov==4.0.0,pytest-timeout==2.0.1,python-dateutil==2.8.2,python-terraform==0.10.1,pytz==2022.6,pyWorkFlow==0.0.2,PyYAML==6.0,redis==4.4.0,redis-benchmarks-specification @ file:///home/fco/redislabs/redis-benchmarks-specification/.tox/.tmp/package/1/redis_benchmarks_specification-0.1.63.tar.gz,redisbench-admin==0.9.31,requests==2.28.1,s3transfer==0.6.0,semver==2.13.0,six==1.16.0,slack-bolt==1.16.0,slack-sdk==3.19.5,smmap==5.0.0,sshtunnel==0.4.0,tabledata==1.3.0,tcolorpy==0.1.2,toml==0.10.2,tomli==2.0.1,tox==3.24.4,tox-docker==4.0.0a2,tqdm==4.64.1,typed-ast==1.5.4,typepy==1.3.0,ujson==5.6.0,urllib3==1.26.13,virtualenv==20.17.1,vulture==2.6,watchdog==2.2.0,websocket-client==1.4.2,Werkzeug==2.2.2,wget==3.2,wrapt==1.14.1,zipp==3.11.0
integration-tests docker: run 'redis/redis-stack-server:7.0.2-RC4' (from 'datasink')
integration-tests docker: run 'redis/redis-stack-server:7.0.2-RC4' (from 'db_server')
integration-tests run-test-pre: PYTHONHASHSEED='4228971603'
integration-tests run-test: commands[0] | black --check redis_benchmarks_specification
All done! ✨ 🍰 ✨
40 files would be left unchanged.
integration-tests run-test: commands[1] | flake8 redis_benchmarks_specification
integration-tests run-test: commands[2] | coverage erase
integration-tests run-test: commands[3] | coverage run '--include=redis_benchmarks_specification/*' -m pytest -ra
===================================================================================================== test session starts ======================================================================================================
platform linux -- Python 3.10.7, pytest-7.2.0, pluggy-1.0.0
cachedir: .tox/integration-tests/.pytest_cache
rootdir: /home/fco/redislabs/redis-benchmarks-specification
plugins: asyncio-0.20.3, timeout-2.0.1, cov-4.0.0
asyncio: mode=strict
collected 25 items                                                                                                                                                                                                             

utils/tests/test_api.py ..                                                                                                                                                                                               [  8%]
utils/tests/test_app.py ..                                                                                                                                                                                               [ 16%]
utils/tests/test_builder.py ....                                                                                                                                                                                         [ 32%]
utils/tests/test_builder_schema.py .                                                                                                                                                                                     [ 36%]
utils/tests/test_cli.py .                                                                                                                                                                                                [ 40%]
utils/tests/test_runner.py ...                                                                                                                                                                                           [ 52%]
utils/tests/test_schema.py ..                                                                                                                                                                                            [ 60%]
utils/tests/test_self_contained_coordinator.py .....                                                                                                                                                                     [ 80%]
utils/tests/test_self_contained_coordinator_memtier.py ...                                                                                                                                                               [ 92%]
utils/tests/test_spec.py .                                                                                                                                                                                               [ 96%]
utils/tests/test_topologies.py .                                                                                                                                                                                         [100%]

======================================================================================================= warnings summary =======================================================================================================
.tox/integration-tests/lib/python3.10/site-packages/_yaml/__init__.py:18
  /home/fco/redislabs/redis-benchmarks-specification/.tox/integration-tests/lib/python3.10/site-packages/_yaml/__init__.py:18: DeprecationWarning: The _yaml extension module is now located at yaml._yaml and its location is subject to change.  To use the LibYAML-based parser and emitter, import from `yaml`: `from yaml import CLoader as Loader, CDumper as Dumper`.
    warnings.warn(

.tox/integration-tests/lib/python3.10/site-packages/invoke/loader.py:3
  /home/fco/redislabs/redis-benchmarks-specification/.tox/integration-tests/lib/python3.10/site-packages/invoke/loader.py:3: DeprecationWarning: the imp module is deprecated in favour of importlib and slated for removal in Python 3.12; see the module's documentation for alternative uses
    import imp

utils/tests/test_builder.py: 105 warnings
utils/tests/test_runner.py: 4 warnings
utils/tests/test_self_contained_coordinator.py: 6 warnings
utils/tests/test_self_contained_coordinator_memtier.py: 10 warnings
  /home/fco/redislabs/redis-benchmarks-specification/.tox/integration-tests/lib/python3.10/site-packages/docker/utils/utils.py:52: DeprecationWarning: distutils Version classes are deprecated. Use packaging.version instead.
    s1 = StrictVersion(v1)

utils/tests/test_builder.py: 105 warnings
utils/tests/test_runner.py: 4 warnings
utils/tests/test_self_contained_coordinator.py: 6 warnings
utils/tests/test_self_contained_coordinator_memtier.py: 10 warnings
  /home/fco/redislabs/redis-benchmarks-specification/.tox/integration-tests/lib/python3.10/site-packages/docker/utils/utils.py:53: DeprecationWarning: distutils Version classes are deprecated. Use packaging.version instead.
    s2 = StrictVersion(v2)

-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
========================================================================================= 25 passed, 252 warnings in 268.65s (0:04:28) =========================================================================================
integration-tests run-test: commands[4] | coverage report -m
Name                                                                                          Stmts   Miss  Cover   Missing
---------------------------------------------------------------------------------------------------------------------------
redis_benchmarks_specification/__api__/__init__.py                                                0      0   100%
redis_benchmarks_specification/__api__/app.py                                                   118     17    86%   46-49, 54, 59-67, 76, 78, 115
redis_benchmarks_specification/__builder__/__init__.py                                            0      0   100%
redis_benchmarks_specification/__builder__/builder.py                                           186     52    72%   54-141, 163-164, 186, 224-241, 254, 280, 357, 365-371, 408-414, 423
redis_benchmarks_specification/__builder__/schema.py                                             13      0   100%
redis_benchmarks_specification/__cli__/__init__.py                                                0      0   100%
redis_benchmarks_specification/__cli__/args.py                                                   36      0   100%
redis_benchmarks_specification/__cli__/cli.py                                                   111     47    58%   44-55, 85, 99-111, 126, 141-172, 175, 188, 196-211, 225-259
redis_benchmarks_specification/__cli__/stats.py                                                 259    251     3%   19-399
redis_benchmarks_specification/__common__/__init__.py                                             0      0   100%
redis_benchmarks_specification/__common__/builder_schema.py                                      86      6    93%   81-86, 114, 151
redis_benchmarks_specification/__common__/env.py                                                 45      1    98%   79
redis_benchmarks_specification/__common__/package.py                                             19     11    42%   10-21
redis_benchmarks_specification/__common__/runner.py                                              84     13    85%   22, 27, 29-40, 45, 50-51, 119-120
redis_benchmarks_specification/__common__/spec.py                                                22      0   100%
redis_benchmarks_specification/__init__.py                                                        6      2    67%   14-15
redis_benchmarks_specification/__runner__/__init__.py                                             0      0   100%
redis_benchmarks_specification/__runner__/args.py                                                42      0   100%
redis_benchmarks_specification/__runner__/runner.py                                             357    106    70%   89-97, 102-103, 139-147, 163-171, 173, 229, 245-248, 314-315, 345, 370-377, 420-425, 437-447, 452-469, 479-485, 488-489, 492, 524-525, 531, 553, 658-659, 725-734, 738-747, 750-760, 764, 769-770, 790-799, 802, 812-817, 821-827, 895-963
redis_benchmarks_specification/__self_contained_coordinator__/__init__.py                         0      0   100%
redis_benchmarks_specification/__self_contained_coordinator__/args.py                            31     28    10%   25-138
redis_benchmarks_specification/__self_contained_coordinator__/artifacts.py                       12      0   100%
redis_benchmarks_specification/__self_contained_coordinator__/build_info.py                      36      1    97%   36
redis_benchmarks_specification/__self_contained_coordinator__/clients.py                          8      0   100%
redis_benchmarks_specification/__self_contained_coordinator__/cpuset.py                          11      0   100%
redis_benchmarks_specification/__self_contained_coordinator__/docker.py                          27     14    48%   37-46, 59-90
redis_benchmarks_specification/__self_contained_coordinator__/prepopulation.py                   22     14    36%   28-86
redis_benchmarks_specification/__self_contained_coordinator__/runners.py                        195    158    19%   88-89, 120-620
redis_benchmarks_specification/__self_contained_coordinator__/self_contained_coordinator.py     320    130    59%   94-228, 285, 317, 325, 351, 400-406, 417-422, 479-488, 564, 690-765, 824-842, 848-854, 857-866, 878-888, 970-975
redis_benchmarks_specification/__setups__/__init__.py                                             0      0   100%
redis_benchmarks_specification/__setups__/topologies.py                                          13      0   100%
---------------------------------------------------------------------------------------------------------------------------
TOTAL                                                                                          2059    851    59%
integration-tests docker: remove '50bc301f3d' (from 'datasink')
integration-tests docker: remove 'fcf12a385b' (from 'db_server')
___________________________________________________________________________________________________________ summary ____________________________________________________________________________________________________________
  integration-tests: commands succeeded
  congratulations :)

@filipecosta90 filipecosta90 changed the title Numpy.dep Updated benchmark config to include resource memory usage. Checking valid memory settings upon CLI runner Dec 26, 2022
@filipecosta90 filipecosta90 merged commit 1ae9e26 into main Dec 26, 2022
@filipecosta90 filipecosta90 deleted the numpy.dep branch December 26, 2022 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant