Skip to content

Fix bug 87 #142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 29, 2022
Merged

Fix bug 87 #142

merged 4 commits into from
Nov 29, 2022

Conversation

slice4e
Copy link
Collaborator

@slice4e slice4e commented Nov 24, 2022 •
edited by filipecosta90
Loading

Fixes #87

It seems that we were deleting "temporary_dir" but not "temporary_dir_client"
This should be fixed now ..

@filipecosta90
Copy link
Contributor

@slice4e please format it:

1 file would be reformatted, 38 files would be left unchanged.

you can do it via:

poetry run black .

filipecosta90
filipecosta90 suggested changes Nov 24, 2022
View reviewed changes
Copy link
Contributor

@filipecosta90 filipecosta90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to reformat using black.

@slice4e
Copy link
Collaborator Author

slice4e commented Nov 25, 2022

@slice4e please format it:

1 file would be reformatted, 38 files would be left unchanged.

you can do it via:

poetry run black .

Done

@filipecosta90 filipecosta90 merged commit d6be093 into redis:main Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@filipecosta90 filipecosta90 filipecosta90 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG]: redis-benchmarks-spec-sc-coordinator is not removing temporary folders after un
2 participants
@slice4e @filipecosta90