Skip to content

Added consumer-id to self contained coordinator. Enables multi consumers #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 16, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions poetry.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[tool.poetry]
name = "redis-benchmarks-specification"
version = "0.1.34"
version = "0.1.35"
description = "The Redis benchmarks specification describes the cross-language/tools requirements and expectations to foster performance and observability standards around redis related technologies. Members from both industry and academia, including organizations and individuals are encouraged to contribute."
authors = ["filipecosta90 <filipecosta.90@gmail.com>","Redis Performance Group <performance@redis.com>"]
readme = "Readme.md"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,13 @@ def create_self_contained_coordinator_args(project_name):
type=str,
default=">",
)
parser.add_argument(
"--consumer-id",
type=int,
default=1,
help="Consumer id for consumer group for platform",
)

parser.add_argument(
"--setups-folder",
type=str,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -182,6 +182,10 @@ def main():
datasink_push_results_redistimeseries = args.datasink_push_results_redistimeseries
grafana_profile_dashboard = args.grafana_profile_dashboard

# Consumer id
consumer_pos = args.consumer_pos
logging.info("Consumer pos {}".format(consumer_pos))

profilers_list = []
profilers_enabled = args.enable_profilers
if profilers_enabled:
Expand Down Expand Up @@ -214,6 +218,7 @@ def main():
grafana_profile_dashboard,
cpuset_start_pos,
redis_proc_start_port,
consumer_pos,
)


Expand Down Expand Up @@ -260,12 +265,18 @@ def self_contained_coordinator_blocking_read(
grafana_profile_dashboard="",
cpuset_start_pos=0,
redis_proc_start_port=6379,
consumer_pos=1,
):
num_process_streams = 0
num_process_test_suites = 0
overall_result = False
consumer_name = "{}-self-contained-proc#{}".format(
get_runners_consumer_group_name(platform_name), "1"
get_runners_consumer_group_name(platform_name), consumer_pos
)
logging.info(
"Consuming from group {}. Consumer id {}".format(
get_runners_consumer_group_name(platform_name), consumer_name
)
)
newTestInfo = conn.xreadgroup(
get_runners_consumer_group_name(platform_name),
Expand Down