Skip to content

Adding --test-time to memtier_benchmark-10Mkeys-load-hash-5-fields-with-100B-values-pipeline-10.yml #100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 11, 2022
Merged

Adding --test-time to memtier_benchmark-10Mkeys-load-hash-5-fields-with-100B-values-pipeline-10.yml #100

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
662ce2b
delete the stopped container by default at tear down
May 5, 2022
6f93554
fix test-time on 4 test-cases.
May 6, 2022
edfd92f
Merge branch 'main' into main
filipecosta90 May 9, 2022
ed07f7b
removed the -n parameter, since it was incompatible with --test-time …
May 9, 2022
42f5b18
reverting commit due to conflict with main
May 9, 2022
90733b3
adding a test-time=180 to testcase memtier_benchmark-10Mkeys-load-has…
May 9, 2022
feff069
Re-order --preserve_temporary_client_dirs --client_aggregated_results…
May 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 17 additions & 11 deletions redis_benchmarks_specification/__runner__/runner.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -506,17 +506,6 @@ def process_self_contained_coordinator_stream(
)
pass

if preserve_temporary_client_dirs is True:
logging.info(
"Preserving temporary client dir {}".format(
temporary_dir_client
)
)
else:
logging.info(
"Removing temporary client dir {}".format(temporary_dir_client)
)
shutil.rmtree(temporary_dir_client, ignore_errors=True)
if client_aggregated_results_folder != "":
os.makedirs(client_aggregated_results_folder, exist_ok=True)
dest_fpath = "{}/{}".format(
Expand All @@ -531,6 +520,23 @@ def process_self_contained_coordinator_stream(
shutil.copy(full_result_path, dest_fpath)
overall_result &= test_result

if preserve_temporary_client_dirs is True:
logging.info(
"Preserving temporary client dir {}".format(
temporary_dir_client
)
)
else:
if "redis-benchmark" in benchmark_tool:
os.remove(full_result_path)
logging.info(
"Removing temporary JSON file".format(full_result_path)
)
shutil.rmtree(temporary_dir_client, ignore_errors=True)
logging.info(
"Removing temporary client dir {}".format(temporary_dir_client)
)

table_name = "Results for entire test-suite".format(test_name)
results_matrix_headers = [
"Test Name",
Expand Down
2 changes: 1 addition & 1 deletion ...test-suites/memtier_benchmark-10Mkeys-load-hash-5-fields-with-100B-values-pipeline-10.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ build-variants:
clientconfig:
run_image: redislabs/memtier_benchmark:edge
tool: memtier_benchmark
arguments: '--test-time 180 "--pipeline" "10" "--data-size" "100" --command "HSET __key__ field1 __data__ field2 __data__ field3 __data__ field4 __data__ field5 __data__" "--command-key-pattern" "P" --key-minimum=1 --key-maximum 10000000 -c 50 -t 4 --hide-histogram'
arguments: '"--pipeline" "10" "--data-size" "100" --command "HSET __key__ field1 __data__ field2 __data__ field3 __data__ field4 __data__ field5 __data__" "--command-key-pattern" "P" --key-minimum=1 --key-maximum 10000000 -c 50 -t 4 --hide-histogram --test-time=180'
resources:
requests:
cpus: "4"
Expand Down
2 changes: 1 addition & 1 deletion ...test-suites/memtier_benchmark-1Mkeys-load-hash-5-fields-with-1000B-values-pipeline-10.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ build-variants:
clientconfig:
run_image: redislabs/memtier_benchmark:edge
tool: memtier_benchmark
arguments: '"--pipeline" "10" "--data-size" "1000" --command "HSET __key__ field1 __data__ field2 __data__ field3 __data__ field4 __data__ field5 __data__" --command-key-pattern="P" --key-minimum=1 --key-maximum 1000000 -c 50 -t 4 --hide-histogram'
arguments: '--test-time 180 "--pipeline" "10" "--data-size" "1000" --command "HSET __key__ field1 __data__ field2 __data__ field3 __data__ field4 __data__ field5 __data__" --command-key-pattern="P" --key-minimum=1 --key-maximum 1000000 -c 50 -t 4 --hide-histogram'
resources:
requests:
cpus: "4"
Expand Down
2 changes: 1 addition & 1 deletion ...ecification/test-suites/memtier_benchmark-1Mkeys-load-hash-5-fields-with-1000B-values.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ build-variants:
clientconfig:
run_image: redislabs/memtier_benchmark:edge
tool: memtier_benchmark
arguments: '"--data-size" "1000" --command "HSET __key__ field1 __data__ field2 __data__ field3 __data__ field4 __data__ field5 __data__" --command-key-pattern="P" --key-minimum=1 --key-maximum 1000000 -c 50 -t 4 --hide-histogram'
arguments: '--test-time 180 "--data-size" "1000" --command "HSET __key__ field1 __data__ field2 __data__ field3 __data__ field4 __data__ field5 __data__" --command-key-pattern="P" --key-minimum=1 --key-maximum 1000000 -c 50 -t 4 --hide-histogram'
resources:
requests:
cpus: "4"
Expand Down