Allow garbage collection of processed queue items #752
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set processed queue items to `null` to allow garbage collection of these items. The command queue contains callbacks. They contain the stack of the current fiber, which can be large. Allow earlier garbage collection of these stacks by removing the reference to the queue items.
|
LGTM |
|
@dohse looks good, but would you mind rebasing and adding a test or two to |
|
@bcoe Hm, what tests should be added here? There is already a test for the function itself so I'd say it's ready to merge. |
|
@BridgeAR fine by me, but let's rebase with master so that we force a full test-suite run ... this does change the behavior of the queue slightly 👍 |
|
As all tests pass with the patch applied, I'll merge it. Thx @dohse |
BridgeAR
added a commit
that referenced
this pull request
Sep 4, 2015
Allow garbage collection of processed queue items
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set processed queue items to
nullto allow garbage collection of theseitems. The command queue contains callbacks. They contain the stack of
the current fiber, which can be large. Allow earlier garbage collection
of these stacks by removing the reference to the queue items.