Skip to content

Update Redis version to 8.0.1-pre #2952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 8, 2025

Conversation

bobymicroby
Copy link
Member

@bobymicroby bobymicroby commented May 8, 2025

since >=8.0.1

FT.AGGREGATE returns an array reply where each row is an array reply
and represents a single aggregate result.
The integer reply at position 1 does not represent a valid value.

We now calculate the result length bazed on the number of results instead of the integer reply at pos 1

@bobymicroby bobymicroby force-pushed the bump-tests-to-8.0.1 branch from c98eb14 to 88efe04 Compare May 8, 2025 10:25
> FT.AGGREGATE returns an array reply where each row is an array reply
and represents a single aggregate result.
> The integer reply at position 1 does not represent a valid value.

We now calculate the result length bazed on the number of results
instead of the integer reply at pos 1
@bobymicroby bobymicroby force-pushed the bump-tests-to-8.0.1 branch from 88efe04 to dd3c376 Compare May 8, 2025 11:28
@bobymicroby bobymicroby requested a review from nkaradzhov May 8, 2025 11:32
Copy link
Collaborator

@nkaradzhov nkaradzhov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bobymicroby bobymicroby merged commit 5e9fea1 into redis:master May 8, 2025
11 checks passed
bobymicroby added a commit to bobymicroby/node-redis that referenced this pull request May 8, 2025
in redis#2952

//  https://redis.io/docs/latest/commands/ft.aggregate/#return
//  FT.AGGREGATE returns an array reply where each row is an array reply and represents a single aggregate result.
// The integer reply at position 1 does not represent a valid value.
bobymicroby added a commit to bobymicroby/node-redis that referenced this pull request May 8, 2025
…dis#2952

> FT.AGGREGATE returns an array reply where each row is an array reply and represents a single aggregate result.
The integer reply at position 1 does not represent a valid value.

https://redis.io/docs/latest/commands/ft.aggregate/#return
bobymicroby added a commit to bobymicroby/node-redis that referenced this pull request May 9, 2025
…dis#2952

> FT.AGGREGATE returns an array reply where each row is an array reply and represents a single aggregate result.
The integer reply at position 1 does not represent a valid value.

https://redis.io/docs/latest/commands/ft.aggregate/#return
bobymicroby added a commit that referenced this pull request May 9, 2025
 (#2955)

> FT.AGGREGATE returns an array reply where each row is an array reply and represents a single aggregate result.
The integer reply at position 1 does not represent a valid value.

https://redis.io/docs/latest/commands/ft.aggregate/#return
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants