Skip to content

fix(client): add type annotations #2949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 7, 2025
Merged

fix(client): add type annotations #2949

merged 1 commit into from
May 7, 2025

Conversation

nkaradzhov
Copy link
Collaborator

@nkaradzhov nkaradzhov commented May 7, 2025 •
edited
Loading

Fix type parameter for transformTuplesReply in CONFIG_GET and HGETALL commands

fixes #2933

Description

Describe your pull request here

Checklist

  • Does npm test pass with this change (including linting)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?

@nkaradzhov
fix(client): add type annotations
e09d0d5 
Fix type parameter for transformTuplesReply in CONFIG_GET and HGETALL commands

fixes redis#2933
@nkaradzhov nkaradzhov requested a review from htemelski May 7, 2025 10:20
htemelski
htemelski reviewed May 7, 2025
View reviewed changes
@nkaradzhov nkaradzhov merged commit 87b77e3 into redis:master May 7, 2025
11 checks passed
@nkaradzhov nkaradzhov deleted the fix-types-mismatch branch May 7, 2025 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@htemelski htemelski htemelski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

5.0.0 HGETALL returns type doesn't make sens in TS
2 participants
@nkaradzhov @htemelski