Skip to content

[CAE-686] Added hash field expiration commands #2907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 19, 2025
Merged

[CAE-686] Added hash field expiration commands #2907

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
476da6d
[CAE-686] Added hash field expiration commands
htemelski-redis Mar 11, 2025
cd06059
[CAE-686] Improve HSETEX return type
htemelski-redis Mar 12, 2025
38da7a4
[CAE-686] Minor pushTuples change, renamed HSETEX test
htemelski-redis Mar 12, 2025
b77db59
[CAE-686] Changed hsetex function signature for better consistency wi…
htemelski-redis Mar 12, 2025
f5fbb92
[CAE-686] Fixed hsetex test
htemelski-redis Mar 12, 2025
f03c758
[CAE-686] Bumped docker version to 8.0-M05-pre, enabled and fixed tests
htemelski-redis Mar 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
[CAE-686] Minor pushTuples change, renamed HSETEX test
  • Loading branch information
@htemelski-redis
htemelski-redis committed Mar 19, 2025
commit 38da7a4b9d389c974b80174fc98ddba4f01f0bca
2 changes: 1 addition & 1 deletion packages/client/lib/commands/HSETEX.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ describe('HSETEX parseCommand', () => {

// TODO: enable when new test container is released
describe.skip('HSETEX call', () => {
testUtils.testWithClientIfVersionWithinRange([[8], 'LATEST'], 'hSetEx empty single field', async client => {
testUtils.testWithClientIfVersionWithinRange([[8], 'LATEST'], 'hSetEx calls', async client => {
assert.deepEqual(
await client.hSetEx('key', {expiration: {type: "EX", value: 500}, mode: "FNX"}, 'filed1', 'value1'),
1
Expand Down
4 changes: 1 addition & 3 deletions packages/client/lib/commands/HSETEX.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,9 +89,7 @@ function pushTuples(parser: CommandParser, tuples: HSETEXTuples): void {
}

parser.push((tmpParser.redisArgs.length/2).toString())
tmpParser.redisArgs.forEach(arg => {
parser.push(arg)
});
parser.push(...tmpParser.redisArgs)
}

function _pushTuples(parser: CommandParser, tuples: HSETEXTuples): void {
Expand Down