fix createCluster - copy options.defaults.socket
before modifying it
#2783
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#2373 introduced a bug into the creation of cluster clients. The issue is that provided options for creating a socket are changed. The function
clientOptionsDefaults
incluster-slots.ts
is called twice once withdisableReconnect
false
and the second call is the real call for creating clients but the functionclientOptionsDefaults
is overridingthis.#options.defaults.socket
at line 289 becauseresult.socket
is the same reference asthis.#options.defaults.socket
fix #2721
Checklist
npm test
pass with this change (including linting)?