Skip to content

Support BITFIELD_RO #2012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Support BITFIELD_RO #2012

wants to merge 2 commits into from

Conversation

Avital-Fine
Copy link
Contributor

Description

Support BITFIELD_RO


Checklist

  • Does npm test pass with this change (including linting)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?

@Avital-Fine Avital-Fine linked an issue Feb 28, 2022 that may be closed by this pull request
@codecov-commenter
Copy link

codecov-commenter commented Feb 28, 2022

Codecov Report

Merging #2012 (f5072bb) into master (ac7d50c) will increase coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head f5072bb differs from pull request most recent head 50da0d3. Consider uploading reports for the commit 50da0d3 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2012      +/-   ##
==========================================
+ Coverage   94.94%   94.95%   +0.01%     
==========================================
  Files         358      359       +1     
  Lines        3343     3350       +7     
  Branches      409      409              
==========================================
+ Hits         3174     3181       +7     
  Misses         85       85              
  Partials       84       84              
Impacted Files Coverage Δ
packages/client/lib/commands/BITFIELD.ts 100.00% <ø> (ø)
packages/client/lib/cluster/commands.ts 100.00% <100.00%> (ø)
packages/client/lib/commands/BITFIELD_RO.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac7d50c...50da0d3. Read the comment docs.

@Didas-git
Copy link
Contributor

Duplicated? #1988

@Avital-Fine
Copy link
Contributor Author

Duplicated? #1988

yep

@leibale leibale deleted the BITFIELD_RO branch July 18, 2022 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for redis command: BITFIELD_RO
3 participants