There is a bug with authentication (please see the commit comment). It should be fixed now.#101
Merged
Merged
Conversation
… and the server is still loading the database: Now the client tries to authenticate again every 2 seconds until actually authenticated. "connect" is only emitted after authentication if authentication is required.
|
Great! I found this bug and spent quite a while tracking it down. Its always nice when someone has it fixed! Thank you! |
mranney
added a commit
that referenced
this pull request
Jun 30, 2011
Fix bug with authentication and LOADING error response.
Contributor
|
Thanks, I've merged this. I need to come up with a way of testing all of these different permutations of reconnection, auth, and the "LOADING" error response. |
mranney
added a commit
that referenced
this pull request
Jun 30, 2011
mranney
added a commit
that referenced
this pull request
Jun 30, 2011
* authentication retry while server is loading db (danmaz74) [GH-101] * command arguments processing issue with arrays New features: * Auto update of new commands from redis.io (Dave Hoover) * Performance improvements and backpressure controls. * Commands now return the true/false value from the underlying socket write(s). * Implement command_queue high water and low water for more better control of queueing. See `examples/backpressure_drain.js` for more information.
Author
|
Glad to have helped :) And thank you for the great work |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed a bug when the client tries to authenticate to the redis server and the server is still loading the database: Now the client tries to authenticate again every 2 seconds until actually authenticated. "connect" is only emitted after authentication if authentication is required.