Plan for cluster support

[crzidea]

Is there any plan for cluster support?
Redis 3.0.0 beta has been released for a month.

[haio]

👍

[asilvas]

Anyone developing this support?

[albarra]

May be we have to re-build the concept of this module.
Today is completly deprecated and still it is recommended by Redis.IO site.

The problem with "cluster support" is that redis still doesn't have it on stable versions. It's on development.

The appropiate issue will be "plan for redis sentinel", i think...

[andzdroid]

I've made a compatible wrapper over node_redis for redis clusters: https://github.com/koyoki/redis-party

[brycebaril]

@albarra -- this is not deprecated at all. Chill out -- it is maintained and we're working on updating the nature of the library to be more compatible with things like sentinel and cluster.

As mentioned in other issues, Redis Sentinel and Redis Cluster support will require removing the reconnection logic from the core of this library. There is a refactor branch where I've started that work and have been rewriting the tests in a way that doesn't also combine the tests with the connection logic.

Once that is done all connection logic (sentinel, cluster, or the existing legacy reconnection logic) will all be available as separate wrappers for this library.

[albarra]

Sorry, what i meant is that in certain situations is deprecated, since it doesn't support HA.
Of course, if you have only one instance of Redis, it's the ideal module. It works perfect! 👍 , and as you said, the module has continuous updates and support. :)
greetings!

[vivekkrbajpai]

@brycebaril 👍

[mc0]

I wrote a redis cluster implementation that is similar to Antirez's ruby version. It simply wraps this redis module but I'd like to see it included with this module if possible. The only change I had to make to redis/index.js1 was to make the raw error object get passed to the on_error method, pass that along when we emit the error, and allow RedisClient#max_attempts to be 0.

I know that @brycebaril is working on a refactor branch that removes the connection logic but I'm not entirely sure that that is required for getting cluster support. I'm sure I just missed the discussion on that but is there a summary for why?

[crzidea]

@mc0
I guess connection shuold be keeped instead of just close it on_error.

[danmaz74]

@brycebaril any updates regarding Redis cluster support? I read there was a refactoring going on, but didn't see any recent updates. Thanks!

[jadbox]

+1 for cluster support

[MetaThis]

+1

[shaharmor]

Redis cluster is out now, any chance to implement support for it now?

[thelinuxlich]

+1

[alumowa]

👍