Skip to content

Refactor tests for clarity and maintainability #3363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 1, 2025
Merged

Refactor tests for clarity and maintainability #3363

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4886000
test: remove redundant assertions and clarify time-related values wit…
Rian-Ismael Jul 17, 2025
10f7989
test: remove redundant assertions and clarify time-related values wit…
Rian-Ismael Jul 17, 2025
de1fc38
test: remove redundant assertions and clarify time-related values wit…
Rian-Ismael Jul 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/test/java/io/lettuce/core/TimeoutOptionsUnitTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,13 +38,15 @@ void defaultConnectionTimeout() {

@Test
void fixedConnectionTimeout() {
final long MINUTES = 1;
final long MINUTE_IN_NANOS = TimeUnit.MINUTES.toNanos(MINUTES);

TimeoutOptions timeoutOptions = TimeoutOptions.enabled(Duration.ofMinutes(1));
TimeoutOptions timeoutOptions = TimeoutOptions.enabled(Duration.ofMinutes(MINUTES));

TimeoutSource source = timeoutOptions.getSource();
assertThat(timeoutOptions.isTimeoutCommands()).isTrue();
assertThat(timeoutOptions.isApplyConnectionTimeout()).isFalse();
assertThat(source.getTimeout(null)).isEqualTo(TimeUnit.MINUTES.toNanos(1));
assertThat(source.getTimeout(null)).isEqualTo(MINUTE_IN_NANOS);
}

}
10 changes: 9 additions & 1 deletion src/test/java/io/lettuce/core/sentinel/SentinelServerCommandIntegrationTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,10 +80,18 @@ void after() {
}

@Test
public void clientGetSetname() {
public void clientGetNameReturnsNullWhenNotSet() {
assertThat(sentinel.clientGetname()).isNull();
}

@Test
public void clientSetNameWithNonEmptyStringSetsNameAndReturnsOk() {
assertThat(sentinel.clientSetname("test")).isEqualTo("OK");
assertThat(sentinel.clientGetname()).isEqualTo("test");
}

@Test
public void clientSetNameWithEmptyStringClearsNameAndReturnsOk() {
assertThat(sentinel.clientSetname("")).isEqualTo("OK");
assertThat(sentinel.clientGetname()).isNull();
}
Expand Down