Add basic connection interruption tests #3292
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
uglide
commented
May 13, 2025
uglide
commented
- Use reactor-netty-http client to interact with the Fault Injector
- Test command execution and PubSub with dmc_restart, network_failure failures injected
- Use reactor-netty-http client to interact with Fault Injector - Test command execution and PubSub with dmc_restart, network_failure failures injected
tishun
reviewed
Jun 2, 2025
Comment on lines
+62
to
+64
| @ParameterizedTest | ||
| @ValueSource(strings = { "dmc_restart", "network_failure" }) | ||
| public void testWithReactiveCommands(String triggerAction) { |
There was a problem hiding this comment.
I was wondering, since this is a scenario, if we would not benefit to have some more verbose way to describe exactly what we are testing. E.g.
https://junit.org/junit5/docs/current/user-guide/#writing-tests-display-names
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.