-
Notifications
You must be signed in to change notification settings - Fork 3.9k
Add configurable retry delay for Sentinel reconnection (#2864) #4379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add configurable retry delay for Sentinel reconnection (#2864) #4379
Conversation
Adds configurable delay strategy for Sentinel subscription retries with exponential backoff and jitter support. Prevents all clients from reconnecting simultaneously when connection is lost. Default: 5000ms constant delay (backward compatible) New: Configurable via RedisSentinelClient.Builder.sentinelReconnectDelay()
Test Results 285 files +2 285 suites +2 11m 37s ⏱️ -16s Results for commit 715232d. ± Comparison against base commit 9adb1c8. This pull request skips 600 tests.♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
src/main/java/redis/clients/jedis/builders/SentinelClientBuilder.java
Outdated
Show resolved
Hide resolved
src/main/java/redis/clients/jedis/builders/SentinelClientBuilder.java
Outdated
Show resolved
Hide resolved
src/main/java/redis/clients/jedis/builders/SentinelClientBuilder.java
Outdated
Show resolved
Hide resolved
src/main/java/redis/clients/jedis/builders/SentinelClientBuilder.java
Outdated
Show resolved
Hide resolved
atakavci
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
just left a few questions.
Adds configurable delay strategy for Sentinel subscription retries with exponential backoff and jitter support. Prevents all clients from reconnecting simultaneously when connection is lost.
Default: 5000ms constant delay (backward compatible)
New: Configurable via RedisSentinelClient.Builder.sentinelReconnectDelay()
Closes #2864