Skip to content

Conversation

@ggivo
Copy link
Collaborator

@ggivo ggivo commented Dec 17, 2025

Adds configurable delay strategy for Sentinel subscription retries with exponential backoff and jitter support. Prevents all clients from reconnecting simultaneously when connection is lost.

Default: 5000ms constant delay (backward compatible)
New: Configurable via RedisSentinelClient.Builder.sentinelReconnectDelay()

Closes #2864

Adds configurable delay strategy for Sentinel subscription retries with
exponential backoff and jitter support. Prevents all clients from reconnecting
simultaneously when connection is lost.

Default: 5000ms constant delay (backward compatible)
New: Configurable via RedisSentinelClient.Builder.sentinelReconnectDelay()
@github-actions
Copy link

github-actions bot commented Dec 17, 2025

Test Results

   285 files  +2    285 suites  +2   11m 37s ⏱️ -16s
10 462 tests +7  9 196 ✅  - 593  1 266 💤 +600  0 ❌ ±0 
 2 767 runs  +7  2 767 ✅ +  7      0 💤 ±  0  0 ❌ ±0 

Results for commit 715232d. ± Comparison against base commit 9adb1c8.

This pull request skips 600 tests.
redis.clients.jedis.commands.commandobjects.CommandObjectsHashCommandsTest[1] ‑ testHgetdel
redis.clients.jedis.commands.commandobjects.CommandObjectsHashCommandsTest[1] ‑ testHgetdelBinary
redis.clients.jedis.commands.commandobjects.CommandObjectsHashCommandsTest[1] ‑ testHgetex
redis.clients.jedis.commands.commandobjects.CommandObjectsHashCommandsTest[1] ‑ testHgetexBinary
redis.clients.jedis.commands.commandobjects.CommandObjectsHashCommandsTest[1] ‑ testHsetex
redis.clients.jedis.commands.commandobjects.CommandObjectsHashCommandsTest[1] ‑ testHsetexBinary
redis.clients.jedis.commands.commandobjects.CommandObjectsHashCommandsTest[2] ‑ testHgetdel
redis.clients.jedis.commands.commandobjects.CommandObjectsHashCommandsTest[2] ‑ testHgetdelBinary
redis.clients.jedis.commands.commandobjects.CommandObjectsHashCommandsTest[2] ‑ testHgetex
redis.clients.jedis.commands.commandobjects.CommandObjectsHashCommandsTest[2] ‑ testHgetexBinary
…

♻️ This comment has been updated with latest results.

@ggivo ggivo requested review from a-TODO-rov and Copilot December 19, 2025 14:21
@ggivo ggivo requested a review from atakavci December 19, 2025 14:22
@ggivo ggivo modified the milestone: 7.3.0 Dec 19, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

atakavci
atakavci previously approved these changes Jan 5, 2026
Copy link
Contributor

@atakavci atakavci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
just left a few questions.

@ggivo ggivo merged commit 76368f9 into master Jan 6, 2026
15 checks passed
@ggivo ggivo deleted the topic/ggivo/2864-configurable-sentinel-reconnect branch January 6, 2026 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Sleeping time not configurable when reconnecting to Sentinel

3 participants