Easier constructors for pipeline classes #2731
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
dolavb
reviewed
Feb 22, 2025
Comment on lines
+29
to
+37
| @Override | ||
| public void close() { | ||
| try { | ||
| super.close(); | ||
| } finally { | ||
| IOUtils.closeQuietly(closeable); | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
Does this close the cache refresher whenever we close a pipeline? A pipeline does not have the same lifecyle as the connection provider, I do not understand this close here.
Collaborator
There was a problem hiding this comment.
@dolavb
Looking at the newly introduced constructor they are creating a fresh
new ClusterConnectionProvider(clusterNodes, clientConfig)
and only in this case preserve it for clean up later.
I think the idea is since we create it inside the constructor, we clean it
There was a problem hiding this comment.
Thanks, I had misread the initialization of the provider to be the setting of the closable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.