Skip to content

Add missing xreadGroup, xread to MultiKeyPipeline #2456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 18, 2021
Merged

Add missing xreadGroup, xread to MultiKeyPipeline #2456

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 29 additions & 0 deletions src/main/java/redis/clients/jedis/MultiKeyPipelineBase.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -776,4 +776,33 @@ public Response<Long> georadiusByMemberStore(final String key, final String memb
client.georadiusByMemberStore(key, member, radius, unit, param, storeParam);
return getResponse(BuilderFactory.LONG);
}


@Override
public Response<List<byte[]>> xread(int count, long block, Map<byte[], byte[]> streams) {
client.xread(count, block, streams);
return getResponse(BuilderFactory.BYTE_ARRAY_LIST);
}

@Override
public Response<List<byte[]>> xreadGroup(byte[] groupname, byte[] consumer, int count, long block,
boolean noAck, Map<byte[], byte[]> streams) {
client.xreadGroup(groupname, consumer, count, block, noAck, streams);
return getResponse(BuilderFactory.BYTE_ARRAY_LIST);
}

@Override
public Response<List<Map.Entry<String, List<StreamEntry>>>> xread(int count, long block,
Map.Entry<String, StreamEntryID>... streams) {
client.xread(count, block, streams);
return getResponse(BuilderFactory.STREAM_READ_RESPONSE);
}

@Override
public Response<List<Map.Entry<String, List<StreamEntry>>>> xreadGroup(String groupname,
String consumer, int count, long block, boolean noAck,
Map.Entry<String, StreamEntryID>... streams) {
client.xreadGroup(groupname, consumer, count, block, noAck, streams);
return getResponse(BuilderFactory.STREAM_READ_RESPONSE);
}
}
6 changes: 6 additions & 0 deletions src/main/java/redis/clients/jedis/commands/MultiKeyBinaryRedisPipeline.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
import redis.clients.jedis.params.MigrateParams;

import java.util.List;
import java.util.Map;
import java.util.Set;

/**
Expand Down Expand Up @@ -98,4 +99,9 @@ Response<Long> georadiusStore(byte[] key, double longitude, double latitude, dou

Response<Long> georadiusByMemberStore(byte[] key, byte[] member, double radius, GeoUnit unit,
GeoRadiusParam param, GeoRadiusStoreParam storeParam);

Response<List<byte[]>> xread(int count, long block, Map<byte[], byte[]> streams);

Response<List<byte[]>> xreadGroup(byte[] groupname, byte[] consumer, int count, long block,
boolean noAck, Map<byte[], byte[]> streams);
}
9 changes: 9 additions & 0 deletions src/main/java/redis/clients/jedis/commands/MultiKeyCommandsPipeline.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,12 +5,15 @@
import redis.clients.jedis.Response;
import redis.clients.jedis.KeyedTuple;
import redis.clients.jedis.SortingParams;
import redis.clients.jedis.StreamEntry;
import redis.clients.jedis.StreamEntryID;
import redis.clients.jedis.ZParams;
import redis.clients.jedis.params.GeoRadiusParam;
import redis.clients.jedis.params.GeoRadiusStoreParam;
import redis.clients.jedis.params.MigrateParams;

import java.util.List;
import java.util.Map;
import java.util.Set;

/**
Expand Down Expand Up @@ -97,4 +100,10 @@ Response<Long> georadiusStore(String key, double longitude, double latitude, dou

Response<Long> georadiusByMemberStore(String key, String member, double radius, GeoUnit unit,
GeoRadiusParam param, GeoRadiusStoreParam storeParam);

Response<List<Map.Entry<String, List<StreamEntry>>>> xread(int count, long block,
Map.Entry<String, StreamEntryID>... streams);

Response<List<Map.Entry<String, List<StreamEntry>>>> xreadGroup(String groupname, String consumer,
int count, long block, boolean noAck, Map.Entry<String, StreamEntryID>... streams);
}