Introduce and extend Config pattern (II/2) #2363
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+214
to
+220
| if (socketParamModified) { // this is only for backward compatibility | ||
| try { | ||
| disconnect(); | ||
| } catch(Exception e) { | ||
| // swallow | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
why do we need disconnect() before connect().
i also think we should not swallow any exception, we need logger.error it.
Contributor
Author
There was a problem hiding this comment.
i also think we should not swallow any exception, we need logger.error it.
acknowledged
why do we need disconnect() before connect().
In current Jedis implementation, it is possible for users to change connection params after constructor. This block of code is present to support those implementations by recreating the connections if the params are changed.
Contributor
Author
|
@yangbodong22011 Let's continue at #2368 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An alternate implementation of #2352.
This approach copies the configuration parameters instead of saving the object reference.