Remove reset after connection was returned to pool #1935
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sazzad16
suggested changes
Jan 17, 2019
Contributor
sazzad16
left a comment
sazzad16
left a comment
There was a problem hiding this comment.
IMHO, you should also replace
Pool<Jedis> pool = this.dataSource;
with
JedisPoolAbstract pool = this.dataSource;
to keep it same as original commit to prevent any future confusion.
Contributor
Author
|
@sazzad16 you can't in 2.10 is was And there was no JedisPoolAbstract |
Contributor
|
@gkorland oh, ok! LGTM! |
Contributor
|
Merged into 2.10. |
jebeaudet
added a commit
to jebeaudet/jedis
that referenced
this pull request
Feb 6, 2019
marcosnils
pushed a commit
that referenced
this pull request
Feb 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1920 (#1918)
Fix bad backport of commit