Skip to content

Conversation

@gkorland
Copy link
Contributor

@gkorland gkorland commented Jul 5, 2018

No description provided.

Copy link
Contributor

@sazzad16 sazzad16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gkorland Great catches! But similar typos should also be found in BinaryJedis and may be some other classes. Could you please look for those and fix? Thanks!

@gkorland
Copy link
Contributor Author

gkorland commented Jul 8, 2018

more more typo fixes

Copy link
Contributor

@sazzad16 sazzad16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

L1292: Change have to leave.

Copy link
Contributor

@sazzad16 sazzad16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@marcosnils @HeartSaVioR As these are minor changes, I'm setting it to READY TO MERGE directly.

@sazzad16 sazzad16 added this to the 2.9.1 milestone Jul 9, 2018
@marcosnils marcosnils merged commit c0b8ac0 into redis:master Aug 1, 2018
marcosnils pushed a commit that referenced this pull request Aug 1, 2018
* Few typo fixes

* Fix more typos

* replace leave with have
marcosnils pushed a commit that referenced this pull request Aug 1, 2018
* Few typo fixes

* Fix more typos

* replace leave with have
@gkorland gkorland deleted the patch-1 branch August 1, 2018 13:17
joyang1 pushed a commit to joyang1/jedis that referenced this pull request Dec 27, 2018
* Few typo fixes

* Fix more typos

* replace leave with have
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants