Repository navigation
fix: reject unfulfilled commands dropped on reconnect - #2194
Merged
PavelPashov merged 1 commit intoSep 14, 2026
Merged
Conversation
On close from ready, in-flight commands are stashed in prevCommandQueue. A successful reconnect replaces commandQueue, so when autoResendUnfulfilledCommands is false the ready handler dropped the stash without rejecting it. flushQueue only walks offlineQueue and commandQueue, so nothing could settle those promises afterwards - not even disconnect(). Reject each stashed command with abortError, matching the other connection-drop paths. Closes redis#2193
nkaradzhov
approved these changes
Sep 11, 2026
nkaradzhov
left a comment
nkaradzhov
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the thorough issue and the fix, LGTM.
I would still defer the final decision to @PavelPashov
PavelPashov
approved these changes
Sep 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2193.
On close from
ready, in-flight commands move toprevCommandQueue. A successfulreconnect replaces
commandQueue, so withautoResendUnfulfilledCommands: falsethe ready handler dropped the stash without rejecting it, and
flushQueueonlywalks
offlineQueueandcommandQueue— leaving those promises unsettleable, evenby
disconnect().Each stashed command is now rejected with
abortError, as you suggested, so theyfail the same way as the other connection-drop paths.
Regression test added to the existing
autoResendUnfulfilledCommandsblock intest/functional/connection.ts: an in-flightBLPOP, a destroyed stream, and anassertion that the promise rejects after reconnect. On
mainit times out at 8s;with the change it passes in ~250ms.