Stability: Support calling redisAsyncCommand and redisAsyncDisconnect from the onConnected callback #931
+103
−17
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is nothing prevengint redisAsyncDisconnect() from being called from the onConnect() callback, and in fact, an application may decide that it doesn't want the connection.
However, redisAsyncDisconnect() will delete the context, before other processing involving the context can finish, when handling the original connection. This causes a crash.
This PR adds the usual callback flag when calling the connect/disconnect callbacks. Any pending disconnect or free is then handled by the __redisAsyncHandleConnect() handler.
It is now safe to delete the collection from the onConnect callback.
Additionally, the REDIS_CONNECTED flag is now set before the onConnect() callback is called, which makes the disconnect logic work correctly from with the callback.
In addition, any other redis commands can be called from the on_connected, such as redisAsyncCommand(), to directly schedule commands for execution.
The PR includes regression tests for both cases.