Makefile: correctly handle version suffixes on macOS #1257
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On macOS, the version suffix of a shared library comes before the `.dylib` suffix, which is different from the convention on other systems. Currently, the Makefile only overrides `DYLIB_MINOR_NAME` for macOS, but does not handle the other similar variables, namely `DYLIB_MAJOR_NAME`, `SSL_DYLIB_MINOR_NAME`, and `SSL_DYLIB_MAJOR_NAME`. This commit fixes the issue by overriding all these variables for macOS. Signed-off-by: Ruoyu Zhong <zhongruoyu@outlook.com>
ZhongRuoyu
force-pushed
the
macos-dylib-suffix
branch
from
cba081a to
f6dc8fc
Compare
|
Gentle ping @michael-grunder -- mind having a look? It'd be nice to have this shipped, and we can apply the fix to Homebrew's hiredis. |
michael-grunder
approved these changes
Feb 10, 2025
|
As far as I can tell this change is correct. Thanks! |
|
Great, thank you @michael-grunder! |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On macOS, the version suffix of a shared library comes before the
.dylibsuffix, which is different from the convention on other systems. Currently, the Makefile only overridesDYLIB_MINOR_NAMEfor macOS, but does not handle the other similar variables, namelyDYLIB_MAJOR_NAME,SSL_DYLIB_MINOR_NAME, andSSL_DYLIB_MAJOR_NAME.This PR fixes the issue by overriding all these variables for macOS.