Allow disabling the -Werror flag. #1210
Merged
+5
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This follows my message in #1193, packagers usually don't want to enable
-Werror, this is only for developers working on Redis itself.Typically right now we tried to upgrade to hiredis 1.2.0, we force using LTO in our builds, and we also build tests (to at least run the test and make sure our toolchain doesn't seem to buggy). With gcc 11, we get lots of false positive warnings in sds.c (wrong stringop-overflow warnings, warning which is known to create quite some problems here and there since it was introduced), which don't come out with gcc 13. Given how old is gcc 11 now and given that it doesn't happen with gcc 13, I doubt that reporting this bugs to the gcc project will help.
So is such an opt-out flag ok or not ? I copied what was done for
USE_SSL.