Skip to content

[CAE-1046] fix(loading): cache the loaded flag for slave nodes #3410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 18, 2025
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion osscluster.go
Original file line number Diff line number Diff line change
Expand Up @@ -340,6 +340,7 @@ type clusterNode struct {
latency uint32 // atomic
generation uint32 // atomic
failing uint32 // atomic
loaded uint32 // atomic

// last time the latency measurement was performed for the node, stored in nanoseconds
// from epoch
Expand Down Expand Up @@ -406,6 +407,7 @@ func (n *clusterNode) Latency() time.Duration {

func (n *clusterNode) MarkAsFailing() {
atomic.StoreUint32(&n.failing, uint32(time.Now().Unix()))
atomic.StoreUint32(&n.loaded, 0)
}

func (n *clusterNode) Failing() bool {
Expand Down Expand Up @@ -449,11 +451,21 @@ func (n *clusterNode) SetLastLatencyMeasurement(t time.Time) {
}

func (n *clusterNode) Loading() bool {
loaded := atomic.LoadUint32(&n.loaded)
if loaded == 1 {
return false
}

// check if the node is loading
ctx, cancel := context.WithTimeout(context.Background(), 100*time.Millisecond)
defer cancel()

err := n.Client.Ping(ctx).Err()
return err != nil && isLoadingError(err)
loading := err != nil && isLoadingError(err)
if !loading {
atomic.StoreUint32(&n.loaded, 1)
}
return loading
}

//------------------------------------------------------------------------------
Expand Down
Loading