Skip to content

utils: export ParseFloat and MustParseFloat wrapping internal utils #3371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 9, 2025
Merged

utils: export ParseFloat and MustParseFloat wrapping internal utils #3371

merged 3 commits into from
May 9, 2025
+147 −5

Conversation

ofekshenawa
Copy link
Collaborator

  • Added utils/convert.go with public wrappers
  • Added tests in utils/convert_test.go

closes #3206

@ofekshenawa ofekshenawa self-assigned this May 7, 2025
@ofekshenawa ofekshenawa requested a review from ndyakov May 7, 2025 19:02
ndyakov
ndyakov approved these changes May 8, 2025
View reviewed changes
Copy link
Member

@ndyakov ndyakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you!

@ndyakov ndyakov marked this pull request as ready for review May 8, 2025 13:28
@ndyakov ndyakov merged commit 42c3284 into master May 9, 2025
25 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndyakov ndyakov ndyakov approved these changes

Assignees

@ofekshenawa ofekshenawa

Labels
feature maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Export float conversion routines (or convert exported data into go types)
2 participants
@ofekshenawa @ndyakov