Skip to content

xinfo-groups: support nil lag in XINFO GROUPS #3369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

xinfo-groups: support nil lag in XINFO GROUPS #3369

wants to merge 2 commits into from

Conversation

ofekshenawa
Copy link
Collaborator

closes #3185

@ofekshenawa ofekshenawa self-assigned this May 7, 2025
@ofekshenawa ofekshenawa added the bug label May 7, 2025
@ofekshenawa ofekshenawa marked this pull request as ready for review May 7, 2025 14:00
@ofekshenawa ofekshenawa requested a review from ndyakov May 7, 2025 14:00
ndyakov
ndyakov approved these changes May 9, 2025
View reviewed changes
Copy link
Member

@ndyakov ndyakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, Can we please update the documentation for the Lag and note that it will return -1 when the Lag is nil.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndyakov ndyakov ndyakov approved these changes

Assignees

@ofekshenawa ofekshenawa

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

XINFO GROUPS can't report that Lag is invalid
2 participants
@ofekshenawa @ndyakov