feat: add TLS URL parameters #2076
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benweissmann
force-pushed
the
bsw/url-tls-options
branch
from
00b356c to
1d70944
Compare
benweissmann
force-pushed
the
bsw/url-tls-options
branch
from
1d70944 to
fae038d
Compare
benweissmann
changed the title
vmihailenco
reviewed
Jun 4, 2022
|
|
||
| o.TLSConfig.MinVersion = uint16(q.int("TLSMinVersion")) | ||
| o.TLSConfig.MaxVersion = uint16(q.int("TLSMaxVersion")) | ||
| o.TLSConfig.InsecureSkipVerify = q.bool("TLSInsecureSkipVerify") |
There was a problem hiding this comment.
Are these options TLSMinVersion/TLSMaxVersion/TLSInsecureSkipVerify documented anywhere?
|
Before merging this, we should check if these or similar options are already used anywhere. If not, we should consider using |
3 tasks
|
@benweissmann @vmihailenco Any updates on this ? |
|
@benweissmann @vmihailenco, any ETA for these changes to be released? |
|
This pull request is marked stale. It will be closed in 30 days if it is not updated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2024