Skip to content

Flaky withConn tests in internal_test.go #2434

Closed
@armsnyder

Description

@armsnyder

I noticed while working on a recent change that the withConn tests in internal_test.go frequently fail with connection errors. However they seem to be passing in the CI.

var _ = Describe("withConn", func() {

The issue is that these tests are running code which needs to make a successful connection to redis on 127.0.0.1:6379, but the test setup does not start redis. In the CI they pass because there is another redis instance started for the purpose of a different test.

These withConn tests are in the redis package instead of redis_test, which is where the BeforeSuite that sets up redis is located.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions