Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to toggle navigation menu entries #205

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

GnaneshKunal
Copy link
Contributor

@GnaneshKunal GnaneshKunal commented May 11, 2024

redis_docs_nav_collapse.mp4

@dwdougherty
Copy link
Collaborator

dwdougherty commented May 11, 2024

Unfortunately, this PR reverses a previous change, which removed the arrow icons from the menus. The consensus of the team is that the arrows provided a bad user experience.

@mich-elle-luna
Copy link
Collaborator

Thank you Gnanesh! Yes, we merged a change to remove the arrows yesterday, but we still need this fix to the toggling. Thanks so much for your time to help with this.

@GnaneshKunal GnaneshKunal marked this pull request as ready for review May 11, 2024 17:03
@GnaneshKunal
Copy link
Contributor Author

GnaneshKunal commented May 11, 2024

Hey @dwdougherty and @mich-elle-luna,

Alright, there has to be some element on which we can enable the toggling functionality will be enabled. The old documentation had a similar arrow bar, and the new documentation had one, too, until we planned to remove it.

We can't enable the toggling functionality on the same list entry because it points to a page.

@mich-elle-luna
Copy link
Collaborator

Hi,
Right, we haven't figured out how to have an arrow for toggling without breaking the nesting hierarchy of the topics in every category and section. So, we need to figure out a way to have the arrow that doesn't change the topic nesting before we can add this functionality. Sorry about that, but we can take some more time to try things out and get it to work eventually. Thanks again.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants