Add long_term_memory_strategy support to client and MCP #82
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add long_term_memory_strategy parameter to client get_or_create_working_memory() and get_or_create_working_memory_tool() - Add long_term_memory_strategy parameter to MCP set_working_memory() tool - Add MemoryStrategyConfig model to client models - Fix documentation example using non-existent 'thread_aware' strategy and incorrect field names - Bump client version to 0.13.0
Contributor
There was a problem hiding this comment.
Pull Request Overview
Adds support for the long_term_memory_strategy parameter to client methods and MCP tools, enabling users to configure memory extraction strategies for promoting working memory to long-term storage.
- Added the
MemoryStrategyConfigmodel to the client package with strategy types (discrete, summary, preferences, custom) - Enhanced client methods
get_or_create_working_memoryandget_or_create_working_memory_toolto accept strategy configuration - Extended MCP
set_working_memorytool to support strategy parameter with proper documentation and examples
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| agent-memory-client/agent_memory_client/models.py | Added MemoryStrategyConfig model and long_term_memory_strategy field to WorkingMemory |
| agent-memory-client/agent_memory_client/client.py | Added strategy parameter support to client methods with examples |
| agent-memory-client/agent_memory_client/init.py | Bumped client version to 0.13.0 |
| agent_memory_server/mcp.py | Added strategy parameter to MCP set_working_memory tool with documentation |
| docs/working-memory.md | Updated documentation with correct strategy examples and field names |
| tests/test_client_strategy_support.py | Added comprehensive client method tests for strategy support |
| tests/test_mcp_strategy_support.py | Added comprehensive MCP tool tests for strategy support |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
The long_term_memory_strategy parameter was documented but not exposed in client methods or the MCP server.
Fixed
Documentation
Testing
Version