Skip to content

Conversation

@abrookins
Copy link
Collaborator

No description provided.

Copilot AI review requested due to automatic review settings May 27, 2025 21:51
@abrookins abrookins merged commit eaf4282 into main May 27, 2025
1 check passed
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the allowed_tools definition in the Claude workflow, consolidating it into a single comma-separated string and adding new tool patterns.

  • Converted multiline YAML list into a single quoted string
  • Introduced new patterns for Python, ruff, uv, pip, pytest, make, etc.
  • Removed the original python -m pytest entry
Comments suppressed due to low confidence (5)

.github/workflows/claude.yml:39

  • There are duplicate entries for Bash(make:*). Please remove one occurrence to avoid redundancy and keep the list clean.
allowed_tools: "Bash,...,Bash(make:*),Bash(pytest:*),..."

.github/workflows/claude.yml:39

  • The pattern Bash(pytest:*) appears twice. Consolidate or remove the duplicate to maintain clarity.
allowed_tools: "Bash,...,Bash(pytest:*),..."

.github/workflows/claude.yml:39

  • Hardcoding the full runner workspace path reduces portability. Consider using ${{ github.workspace }} or running commands relative to the default working directory instead.
allowed_tools: "...,Bash(cd /home/runner/work/agent-memory-server/agent-memory-server && ruff check),Bash(cd /home/runner/work/agent-memory-server/agent-memory-server && pytest*)"

.github/workflows/claude.yml:39

  • The original Bash(python -m pytest) entry was removed, which may prevent invoking tests via python -m pytest. Re-add it or ensure the new patterns cover that common invocation.
allowed_tools: "Bash,Bash(python:*),Bash(ruff:*),..."

.github/workflows/claude.yml:39

  • [nitpick] This single-line, comma-separated string is hard to read and maintain. Consider using a YAML list or multiline literal block to improve readability and ease future edits.
allowed_tools: "Bash,Bash(python:*),...View,GlobTool,GrepTool,BatchTool,..."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants