Open
Conversation
Add 19 Playwright E2E tests for the database list page covering search (query, partial, case-insensitive, host:port, clear, no results), column configuration, selection (single, multiple, all, bulk delete), row actions (edit, clone, connect), and Redis Stack icon verification. References: #RI-7998 Made-with: Cursor
pd-redis
requested review from
ArtemHoruzhenko,
DimoHG,
KrumTy,
dantovska,
pawelangelow and
valkirilov
as code owners
🛡️ Jit Security Scan Results
✅ No security findings were detected in this PR
Security scan by Jit
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
tests/e2e-playwright/tests/main/databases/list/database-list.spec.ts
Outdated
Show resolved
Hide resolved
Refactor the test for verifying the Redis Stack icon in the database list to check for module icons instead. This change improves the robustness of the test by ensuring it correctly identifies the presence of modules associated with the standalone database. References: #RI-7998
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add 19 Playwright E2E tests for the database list page (TEST_PLAN.md section 1.2). Tests are organized by feature area:
3 test cases left unimplemented (connection status indicator, search by connection type, search by last connection time) as they require deeper UI exploration.
Testing
npx playwright test tests/main/databases/list/database-list.spec.tswith local Redis instances (standalone + cluster)Closes #RI-7998
Made with Cursor
Note
Medium Risk
Adds a sizeable new Playwright E2E suite that performs UI selection and bulk-delete flows; main risk is increased CI runtime/flakiness and reliance on stable test environments, not production behavior.
Overview
Adds a new Playwright E2E spec (
database-list.spec.ts) covering the database list page, including search behavior, column visibility toggling, row selection (single/multi/all) with bulk delete, and row actions (edit/clone/connect) plus a Redis Stack icon check.Updates
TEST_PLAN.mdto mark the corresponding Database List (section 1.2) cases as implemented.Written by Cursor Bugbot for commit 5031929. This will update automatically on new commits. Configure here.