Open
Conversation
Add 8 Playwright E2E tests for cloning database connections: pre-populated form, same/new name, cancel, back to edit, cluster, badge verification, and list presence. References: #RI-7999 Made-with: Cursor
pd-redis
requested review from
ArtemHoruzhenko,
DimoHG,
dantovska,
pawelangelow and
valkirilov
as code owners
🛡️ Jit Security Scan Results
✅ No security findings were detected in this PR
Security scan by Jit
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Refactor the afterEach hook to ensure proper cleanup of cloned databases. The updated logic checks for known database IDs to avoid deleting essential databases and handles cases where no cloned names exist. References: #RI-7999
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add 8 Playwright E2E tests for cloning database connections (TEST_PLAN.md section 1.3). Tests cover pre-populated form verification, cloning with same/new name, cancel and back navigation, cluster database cloning, badge verification, and list presence after cloning.
Sentinel clone test left as not-implemented since it requires Sentinel infrastructure.
Testing
npx playwright test tests/main/databases/clone/clone-database.spec.tswith local Redis instances (standalone + cluster)Closes #RI-7999
Made with Cursor
Note
Low Risk
Test-only changes; main risk is potential CI flakiness due to new UI/E2E assertions and reliance on standalone/cluster test Redis instances.
Overview
Adds a new Playwright spec (
clone-database.spec.ts) that exercises the Edit → Clone flow for standalone and OSS cluster connections, including form prefill checks, cloning with same/new names, cancel/back navigation, and post-clone validations (list presence and "New" badge).Updates
TEST_PLAN.mdsection 1.3 Clone Database to mark these clone scenarios as implemented, leaving the Sentinel clone case still unimplemented.Written by Cursor Bugbot for commit 6bdcd05. This will update automatically on new commits. Configure here.