[RI-6004] Delete Certificates #3796
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GnaneshKunal
force-pushed
the
feature/RI-6004-delete-certificates
branch
from
fe9a88a to
d5b2058
Compare
Contributor
|
I don't see changes on backend. Was it implemented? |
rsergeenko
reviewed
Sep 6, 2024
rsergeenko
reviewed
Sep 6, 2024
rsergeenko
reviewed
Sep 6, 2024
GnaneshKunal
force-pushed
the
feature/RI-6004-delete-certificates
branch
5 times, most recently
from
2a98ff8 to
695ea84
Compare
rsergeenko
reviewed
Sep 9, 2024
| event: TelemetryEvent.CONFIG_DATABASES_CERTIFICATE_REMOVED, | ||
| eventData: {}, | ||
| }) | ||
| showPopover(id) |
Contributor
There was a problem hiding this comment.
I think showPopover we should call before deletion
Contributor
Author
There was a problem hiding this comment.
Removed this snippet as it's not required.
Contributor
Author
There was a problem hiding this comment.
The popover component showPopover will show the popover. The telemetry event is sent after the certificate is removed, and we don't require showPopover because the popover is already available at that time. The Popover component's closePopover method closes the popover.
Contributor
There was a problem hiding this comment.
yes, you are right, thanks
rsergeenko
previously approved these changes
Sep 9, 2024
rsergeenko
previously approved these changes
Sep 10, 2024
mariasergeenko
dismissed stale reviews from rsergeenko and ArtemHoruzhenko
via
432b075
mariasergeenko
requested review from
ViktarStarastsenka and
egor-zalenski
as code owners
egor-zalenski
previously approved these changes
Sep 20, 2024
ViktarStarastsenka
previously approved these changes
Sep 20, 2024
GnaneshKunal
dismissed stale reviews from ViktarStarastsenka and egor-zalenski
via
4a17391
Signed-off-by: Gnanesh <gnaneshkunal@outlook.com>
Signed-off-by: Gnanesh <gnaneshkunal@outlook.com>
Signed-off-by: Gnanesh <gnaneshkunal@outlook.com>
Signed-off-by: Gnanesh <gnaneshkunal@outlook.com>
Signed-off-by: Gnanesh <gnaneshkunal@outlook.com>
Fix message in at other place too
the old cert which will fail the getFormUpdates diff logic
TLS certificate to fix the UI issue
GnaneshKunal
force-pushed
the
feature/RI-6004-delete-certificates
branch
from
4a17391 to
b09dd32
Compare
mariasergeenko
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow users to delete CA and client certificates.