Skip to content

mark TOPK.COUNT as deprecated #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 2, 2023
Merged

mark TOPK.COUNT as deprecated #52

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
65c6634
mark TOPK.COUNT as deprecated
shacharPash Dec 29, 2022
52e8af6
change 'since' to as of
shacharPash Dec 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/NRedisStack/TopK/ITopKCommands.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,11 @@ public interface ITopKCommands
/// <param name="item">Items to be counted.</param>
/// <returns>count for responding item.</returns>
/// <remarks><seealso href="https://redis.io/commands/cf.count"/></remarks>
[Obsolete("TOPK.COUNT is deprecated since Bloom 2.4.0")]
Copy link
Contributor

@chayim chayim Dec 29, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead of 'since' use as of

long[] Count(RedisKey key, params RedisValue[] items);

/// <inheritdoc cref="Count(RedisKey, RedisValue[])"/>
[Obsolete("TOPK.COUNT is deprecated since Bloom 2.4.0")]
Copy link
Contributor

@chayim chayim Dec 29, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead of 'since' use as of

Task<long[]> CountAsync(RedisKey key, params RedisValue[] items);


Expand Down