Skip to content

Bump Redis 8.0 version(8.0-RC1-pre) in pipeline #407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Apr 10, 2025
Merged

Bump Redis 8.0 version(8.0-RC1-pre) in pipeline #407

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
d75624a
Bump Redis 8.0 version(8.0-RC1-pre) in pipeline
atakavci Apr 3, 2025
d5f290d
drop/fix failing tests with 8.0
atakavci Apr 3, 2025
4a9b95f
fix failing test
atakavci Apr 3, 2025
5ce7767
Merge branch 'master' into ali/8.0-RC1-pre
atakavci Apr 8, 2025
dbd0db0
fix flaky test
atakavci Apr 8, 2025
98a635c
attempt with await
atakavci Apr 8, 2025
0186b02
check with completed count
atakavci Apr 8, 2025
4819d4e
- remove cancelled
atakavci Apr 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/integration.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ jobs:
max-parallel: 15
fail-fast: false
matrix:
redis-version: [ '8.0-M05-pre', '${{ needs.redis_version.outputs.CURRENT }}', '7.2.6', '6.2.16']
redis-version: [ '8.0-RC1-pre', '${{ needs.redis_version.outputs.CURRENT }}', '7.2.6', '6.2.16']
dotnet-version: ['6.0', '7.0', '8.0']
env:
ACTIONS_ALLOW_UNSECURE_COMMANDS: true
Expand Down
4 changes: 2 additions & 2 deletions tests/NRedisStack.Tests/Search/SearchTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1384,7 +1384,7 @@ public void TestDropIndex(string endpointId)
}
catch (RedisServerException ex)
{
Assert.Contains("no such index", ex.Message);
Assert.Contains("no such index", ex.Message, StringComparison.OrdinalIgnoreCase);
}
Assert.Equal("100", db.Execute("DBSIZE").ToString());
}
Expand Down Expand Up @@ -1417,7 +1417,7 @@ public async Task TestDropIndexAsync(string endpointId)
}
catch (RedisServerException ex)
{
Assert.Contains("no such index", ex.Message);
Assert.Contains("no such index", ex.Message, StringComparison.OrdinalIgnoreCase);
}
Assert.Equal("100", db.Execute("DBSIZE").ToString());
}
Expand Down
4 changes: 0 additions & 4 deletions tests/NRedisStack.Tests/TimeSeries/TestDataTypes/TestTimeSeriesInformation.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,14 +27,12 @@ public void TestInformationSync()
TimeSeriesInformation info = ts.Info(key);
TimeSeriesInformation infoDebug = ts.Info(key, debug: true);

Assert.Equal(4184, info.MemoryUsage);
Assert.Equal(0, info.RetentionTime);
Assert.Equal(1, info.ChunkCount);
Assert.Null(info.DuplicatePolicy);
Assert.Null(info.KeySelfName);
Assert.Null(info.Chunks);

Assert.Equal(4184, infoDebug.MemoryUsage);
Assert.Equal(0, infoDebug.RetentionTime);
Assert.Equal(1, infoDebug.ChunkCount);
Assert.Null(infoDebug.DuplicatePolicy);
Expand All @@ -55,14 +53,12 @@ public async Task TestInformationAsync()
TimeSeriesInformation info = await ts.InfoAsync(key);
TimeSeriesInformation infoDebug = await ts.InfoAsync(key, debug: true);

Assert.Equal(4184, info.MemoryUsage);
Assert.Equal(0, info.RetentionTime);
Assert.Equal(1, info.ChunkCount);
Assert.Null(info.DuplicatePolicy);
Assert.Null(info.KeySelfName);
Assert.Null(info.Chunks);

Assert.Equal(4184, infoDebug.MemoryUsage);
Assert.Equal(0, infoDebug.RetentionTime);
Assert.Equal(1, infoDebug.ChunkCount);
Assert.Null(infoDebug.DuplicatePolicy);
Expand Down
Loading