Skip to content

Conversation

@shacharPash
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

Codecov Report

Patch and project coverage have no change.

Comparison is base (1981625) 93.29% compared to head (bfcf3f2) 93.29%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #103   +/-   ##
=======================================
  Coverage   93.29%   93.29%           
=======================================
  Files          77       77           
  Lines        4576     4576           
  Branches      423      423           
=======================================
  Hits         4269     4269           
  Misses        185      185           
  Partials      122      122           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@shacharPash shacharPash requested a review from a team April 2, 2023 13:45
Assert.True(ft.Create(index, FTCreateParams.CreateParams(), sc));

//sleep:
System.Threading.Thread.Sleep(2000);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you need this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sometimes in the CI ft.Create command takes time and it causes errors in the tests, sleep makes sure that the command has finished running before the assertions

@shacharPash shacharPash requested a review from vladvildanov April 4, 2023 12:41
@shacharPash shacharPash merged commit ef71516 into master Apr 4, 2023
@shacharPash shacharPash deleted the integration branch April 4, 2023 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants