Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduces explicit auth credentials for sentinels #137

Merged
merged 3 commits into from
Aug 30, 2023
Merged

Introduces explicit auth credentials for sentinels #137

merged 3 commits into from
Aug 30, 2023

Conversation

moofkit
Copy link
Contributor

@moofkit moofkit commented Aug 23, 2023

Related with redis/redis-rb#1213 (comment)

This PR:

  • introduces explicit sentinel_username and sentinel_password options for RedisClient#sentinel
  • drops previous default behaviour by substitution credentials to Redis instance for Sentinel too (this may brake some client code that already relay on this)

I'm not sure about second change, so open to how make it better!

@moofkit moofkit marked this pull request as draft August 23, 2023 12:14
@moofkit moofkit marked this pull request as ready for review August 23, 2023 12:26
@casperisfine casperisfine merged commit 70fdae5 into redis-rb:master Aug 30, 2023
12 checks passed
@moofkit moofkit deleted the fix-wrong-pwd-error branch August 30, 2023 13:45
@moofkit moofkit mentioned this pull request Sep 1, 2023
Closed
@stanhu stanhu mentioned this pull request Sep 6, 2023
Closed
@moofkit moofkit mentioned this pull request Sep 7, 2023
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@moofkit @casperisfine