SentinelConfig: handle role possibly being a string #134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sometimes the redis options are provided as a hash with string values. Given that only the role is expected to be a symbol, It is a much better user experience if the conversion was handled internally by the library instead of requiring the user to handle it themselves.
dhruvCW
force-pushed
the
handle_string_role
branch
from
2d1f129 to
4aa9519
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sometimes the redis options are provided as a hash with string values.
This is true in my case where the configurations are read as a json object from an environment variable.
Given that only the role is expected to be a symbol, It is a much better user experience if the conversion was handled internally by the library instead of requiring the user to handle it themselves.