Merge pull request #151 from redis-rb/validate-db-argument

Eagerly fail if db parameter isn't an Integer
redis-rb · Nov 13, 2023 · ba8848b · ba8848b
2 parents 3a1b4f8 + 9007f5d
commit ba8848b
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,7 @@
 # Unreleased
 
+- Eagerly fail if `db:` isn't an Integer. #151.
+
 # 0.18.0
 
 - Expose more connection details such as `host`, `db`, etc on `RedisClient`.

diff --git a/lib/redis_client/config.rb b/lib/redis_client/config.rb
@@ -41,7 +41,12 @@ def initialize(
       )
         @username = username
         @password = password
-        @db = db || DEFAULT_DB
+        @db = begin
+          Integer(db || DEFAULT_DB)
+        rescue ArgumentError
+          raise ArgumentError, "db: must be an Integer, got: #{db.inspect}"
+        end
+
         @id = id
         @ssl = ssl || false