Fix off-by-one errors in rate limiting samples.#613
Open
kimsey0 wants to merge 2 commits intoredis-developer:masterfrom
Open
Fix off-by-one errors in rate limiting samples.#613kimsey0 wants to merge 2 commits intoredis-developer:masterfrom
kimsey0 wants to merge 2 commits intoredis-developer:masterfrom
Conversation
Code increments number of requests, then checks if result is less than max allowed requests. This causes the last request to be denied incorrectly. The text also describes the correct operator as less than or equal to.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The scripts in the two samples increments then number of requests made, then checks if the result is less than the max allowed number of requests. This causes the last request to be denied incorrectly. This pull requests upgrades to the correct less-than-or-equal-to operator, matching the text. It also updates a sample output to have the correct number of allowed requests.