fix: AsyncRedisSaver aget_tuple returning None for checkpoint_id #65
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes issue where AsyncRedisSaver.aget_tuple() returned None for checkpoint_id when no checkpoint_id was specified in the config, while RedisSaver.get_tuple() correctly returned the retrieved checkpoint ID. The bug was caused by using the original checkpoint_id parameter (which may be None) instead of doc_checkpoint_id (the actual ID retrieved from Redis document). Fixed two locations in aget_tuple method: - Config construction: Use doc_checkpoint_id instead of checkpoint_id - _aload_pending_writes call: Use doc_checkpoint_id to match sync behavior Added comprehensive test coverage to verify the fix and prevent regression. Resolves #64 Co-authored-by: Tyler Hutcherson <tylerhutcherson@users.noreply.github.com>
|
This appears to be the correct fix. You can see that the sync version works the same way here: https://github.com/redis-developer/langgraph-redis/blame/0899d7415fa81640f642539c043bc93285415dc2/langgraph/checkpoint/redis/__init__.py#L462 |
|
Have been facing the issue of repeated interrupts because of this. Verified on my local machine, the checkpointer works correctly after applying this fix. Please merge and release this, can't use the AsyncRedisSaver in my agents without this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue where AsyncRedisSaver.aget_tuple() returned None for checkpoint_id when no checkpoint_id was specified in the config, while RedisSaver.get_tuple() correctly returned the retrieved checkpoint ID.
The bug was caused by using the original checkpoint_id parameter (which may be None) instead of doc_checkpoint_id (the actual ID retrieved from Redis document).
Fixed two locations in aget_tuple method:
Added comprehensive test coverage to verify the fix and prevent regression.
Resolves #64
Generated with Claude Code