Skip to content

feat: extend RedisVL version support to 0.7.0 #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 30, 2025

Conversation

bsbodden
Copy link
Contributor

  • Update RedisVL dependency constraint from ^0.5.1 to >=0.5.1,<0.8.0
  • Fix test compatibility to handle error message changes between RedisVL versions
  • Update MockRedis class to inherit from Redis base class for RedisVL 0.7.0 type checking
  • Ensure backwards compatibility with RedisVL 0.5.1 through 0.7.x

The library now supports the latest RedisVL 0.7.0 while maintaining compatibility
with older versions. Tests use regex patterns to handle different error message
formats across RedisVL versions.

  - Update RedisVL dependency constraint from ^0.5.1 to >=0.5.1,<0.8.0
  - Fix test compatibility to handle error message changes between RedisVL versions
  - Update MockRedis class to inherit from Redis base class for RedisVL 0.7.0 type checking
  - Ensure backwards compatibility with RedisVL 0.5.1 through 0.7.x

  The library now supports the latest RedisVL 0.7.0 while maintaining compatibility
  with older versions. Tests use regex patterns to handle different error message
  formats across RedisVL versions.
@bsbodden bsbodden requested review from abrookins and Copilot May 30, 2025 15:19
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR extends RedisVL support to version 0.7.0 by updating dependency constraints, adjusting the MockRedis class for type compatibility, and normalizing test error matching across versions.

  • Bumps redisvl constraint to >=0.5.1,<0.8.0 in pyproject.toml
  • Updates tests to use a union regex for old/new REDIS_URL error messages
  • Modifies MockRedis to inherit from Redis and override attribute access

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
tests/test_sync.py Expanded error‐message regex to support both formats
tests/test_shallow_sync.py Same regex update for shallow‐sync tests
tests/test_interruption.py MockRedis now subclasses Redis, adds super().__init__ and switches to __getattribute__
pyproject.toml Adjusted redisvl dependency range
README.md Removed code‐block formatting inconsistency for install command
Comments suppressed due to low confidence (2)

tests/test_interruption.py:47

  • Overriding getattribute can introduce subtle bugs and recursion issues. Consider using getattr for proxying missing attributes or explicitly delegating only unhandled names to simplify behavior and preserve base-class semantics.
def __getattribute__(self, name):

README.md:330

  • [nitpick] The inline backticks inside a fenced code block are unnecessary and may impede copy-paste. Removing the inner backticks will make the command clearer.
`poetry install --all-extras`

Copy link
Contributor

@abrookins abrookins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 👍

@bsbodden bsbodden merged commit cd5f5bd into main May 30, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants