Convert to using python binary directly instead of alternatives #42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This relates to RPOPC-250 |
dvalinrh
added
the
group_review_lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the script to use the python binary directly instead of going through
update-alternatives. This is useful since the script will not touch what the default python interpreter is on a system.As a result, we may need to get pip through the
ensurepipmodule, since sometimes pip is not packaged for a python version (usually for RHEL-based OS's only thepython3package has support for installing pip via the package manager), this PR adds a way for pip to be installed viaensurepip(disabled by default).Before/After Comparison
Before
If an alternative python interpreter is needed, we would use
update-alternativesso it would become the system's default interpreter.After
A python binary would be specified and used directly.
Clerical Stuff
This closes #25 and will fix #21 .
Relates to JIRA: RPOPC-250
Relates to JIRA: RPOPC-251