Start using new package management system #61
Conversation
Convert ad-hoc package management to be managed by wrapper.yaml, which is passed to test_tool-wrapper's package_tool. This will keep packages that the wrapper needs version controlled with the wrapper. Co-developed-by: Cursor
… into dep-update Co-developed-by: Cursor
wrapper.json
Outdated
| "make", | ||
| "sed", | ||
| "gawk", | ||
| "gcc", |
There was a problem hiding this comment.
I'm not seeing gcc in the existing config file, but git's missing. Making sure this isn't a typo, although without git we won't be checking this list in the first place.
There was a problem hiding this comment.
Actually in the disconnected case (e.g. partner labs that have working repos but no connection to the Internet), if the wrapper is copied manually then we'll get all this way without git. I believe we do have some wrappers that git clone or wget that we'll have to fix for the disconnected case - so far I've been just editing them manually, but I should be filing issues so they can get fixed. Bad engineer, bad bad!
There was a problem hiding this comment.
gcc is required, just not documented..
This list should be very verbose about what packages are required (IE bc, sed, and gawk).
We'll need to figure out how to deal with disconnected environments later, since Zathras assumes it can download the wrapper tarballs on the system under test.
There was a problem hiding this comment.
re: disconnected - my point in this case isn't to expect full support, rather to point out that we can't assume we must have git installed because the wrapper is running. The rest of the disconnected stuff is, yes, NOTTHISBUG.
There was a problem hiding this comment.
Fair enough. I was just thinking "if we're running package_tool, then we must have gotten test-tools-wrapper already, either by git or some other means rendering git moot."
wrapper.json
Outdated
There was a problem hiding this comment.
Can we call it something like "coremark-wrapper.json"? It's a nit, but it might cause confusion or inadvertent overwriting if someone's copying it or sending it to someone.
There was a problem hiding this comment.
We can call it whatever we want, @dvalinrh any thoughts on this?
My general thought process on that is to have a common name (wrapper.json) that we can point people to if they want to use the wrappers, but not a big deal if we want to go for a different convention.
Co-developed-by: Cursor
|
This relates to RPOPC-660 |
grdumas
added
the
group_review_lgtm
Description
Convert ad-hoc package management to be managed by wrapper.yaml, which is passed to test_tool-wrapper's package_tool. This will keep packages that the wrapper needs version controlled with the wrapper.
Before/After Comparison
Before
Dependencies were split between wrappers and Zathras's test definitions.
After
Dependencies are solely listed in the wrapper.json file, and this is passed to
package_toolto manage the installation.Clerical Stuff
Issue #64
Relates to JIRA: RPOPC-660